Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch pack #1 #3

Merged
merged 7 commits into from
Aug 8, 2024
Merged

Patch pack #1 #3

merged 7 commits into from
Aug 8, 2024

Conversation

lakkeger
Copy link
Contributor

@lakkeger lakkeger commented Aug 5, 2024

Motivation

After release we've noticed a couple of different issues.

  • some Debian versions containing pipx only in backports
  • note on that the feature does not managing underlying tools for wrapper scripts
  • 3.6.0 had been released
  • would be nice if LS CLI and the wrapper scripts would be installed AFTER the underlying tool(s) (they are not hard dependencies)
  • check and warn for missing underlying tool

Changes

  • added focal and bullseye support with backports repo
  • 3.6.0 added as proposal
  • underlying tools are added as soft dependencies
  • check and warn for any underlying tool if its wrapper installed

@lakkeger lakkeger marked this pull request as ready for review August 6, 2024 11:43
@lakkeger lakkeger requested a review from dfangl August 6, 2024 11:44
dfangl
dfangl approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lakkeger lakkeger merged commit 2d614f6 into main Aug 8, 2024
6 checks passed
@lakkeger lakkeger deleted the patch_initial_version branch August 8, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lakkeger @dfangl