Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create LocalStack feature #1

Merged
merged 11 commits into from
Jun 21, 2024
Merged

Create LocalStack feature #1

merged 11 commits into from
Jun 21, 2024

Conversation

lakkeger
Copy link
Contributor

@lakkeger lakkeger commented Jun 19, 2024

Motivation

DevContainers giving the option to add so called Features which are building blocks users can add to their DevContainer Template/Collection/Environment. This would be a nice simple addition for any user who’d like to include LocalStack CLI and tools but doesn’t want to rely on our Template.

Changes

  • Implemented capabilities:
    • install LocalStack CLI
    • allow only a list of values
      • latest
      • lts
      • stable
      • none
      • ""(empty)
      • 3.5.0
      • 3.4.0
      • 3.3.0
      • 3.2.0
      • 3.1.0
      • 3.0.2
      • 3.0.1
    • install awscli-local
    • install aws-cdk-local
    • install terraform-local
    • install pulumi-local
    • install aws-sam-cli-local
    • install dependencies via OS packages
    • install dependencies via pip
    • add other features to installAfter
  • Implemented tests:
    • install with version:latest with OS package
    • install with version:lts with OS package
    • install with version:stable with OS package
    • install with version:none with OS package
    • install with version:empty with OS package
    • install with specific version
    • install with python
    • install with python on python image
    • install with OS package on python image
    • install one python based tool
    • install one node based tool relying on the node feature
    • install multiple tools relying on other features
  • Adjust CI
  • Clean up original examples
  • Add new README

@lakkeger lakkeger requested a review from pinzon June 19, 2024 16:42
Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lakkeger lakkeger force-pushed the localstack_feature branch from 8871bdb to 06c0db8 Compare June 21, 2024 11:25
@lakkeger lakkeger merged commit 37bf281 into main Jun 21, 2024
@lakkeger lakkeger deleted the localstack_feature branch June 21, 2024 11:48
lakkeger added a commit that referenced this pull request Aug 8, 2024
* fix: add 3.6.0 into proposals

* feat: add soft dependencies for related tools

* docs: add note about tool installs

* feat: add backports repo for new packages

* fix: add check for missing underlying tools

* feat: add focal and bullseye scenarios

* fix: change section on tools to note for better visibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants