Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with MacOS/ZSH Installation specifics #87

Merged

Conversation

jlargs64
Copy link
Contributor

@jlargs64 jlargs64 commented Oct 9, 2024

Following the conversation in issue #86, the following PR is made to help clarify potential issue with macOS or ZSH installs with pip.

Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution, @jlargs64!
But maybe we could really just add the comments to the command listed above? People don't like reading, and the section below might be overlooked? What do you think?

@alexrashed alexrashed linked an issue Oct 9, 2024 that may be closed by this pull request
@jlargs64
Copy link
Contributor Author

jlargs64 commented Oct 9, 2024

@alexrashed Sure! I moved it higher in the README and shorted it to have less words. Does that look more like what you wanted?

Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution and addressing the comments, @jlargs64!
I'll merge this right away. 🥳

@alexrashed alexrashed merged commit 034919b into localstack:master Oct 9, 2024
6 checks passed
@jlargs64 jlargs64 deleted the update-readme-with-macos-information-1 branch October 9, 2024 13:48
@jlargs64
Copy link
Contributor Author

jlargs64 commented Oct 9, 2024

You're welcome @alexrashed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Install Command in README
2 participants