Fix/support for floating point #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloutierMat
commented
Nov 12, 2024
| @@ -12,6 +12,10 @@ | |||
| LOG = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| # This can be used by a function to bypass the silent behavior of a FormalReference. | |||
| # If a function returns this value instead of None, the origial text of the reference will be returned instead. | |||
| REPLACE_FORMAL_TEXT = "__FORMAL_REFERENCE__REPLACE_TEXT__" | |||
There was a problem hiding this comment.
I am not sure about that name, I am welcome to a suggestion to make it more obvious as to what it does. 🤔
simonrw
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While implementing
$util.mathfor appsync, I realised that while aws was recognising.5as a floating point, airspeed did not.This pr makes the leading digits optional when evaluating a floating point element.
I also added a mechanism by which a function can bypass the default
silentbehavior ofFormalReference. This is relevant for most$utilimplemented in appsync as for example$util.math.roundNumwill return the statement the parameter is either empty or a non Number.