Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for string matches #18

Merged
merged 7 commits into from
Oct 25, 2024
Merged

Conversation

cloutierMat
Copy link

@cloutierMat cloutierMat commented Oct 24, 2024

Motivation

This pr adds support string utility matches. The functionality itself was fairly straightforward but some changes to StringLiteral were required to fully support regular expressions. Notably we were only allowing certain characters to be escaped in string literals, while aws accepts anything. No tests seemed to depend on the escaped character restriction, but it should be safer to run a full suite of localstack tests to ensure this does not create any unforeseen regressions.

Since localstack has gone through a big code restructure since last time this code was change, I have had to update conftest and the main.yml configuration to be inline with latest development

@cloutierMat cloutierMat self-assigned this Oct 24, 2024
@cloutierMat cloutierMat added bug Something isn't working enhancement New feature or request labels Oct 24, 2024
@cloutierMat cloutierMat marked this pull request as ready for review October 24, 2024 22:49
Copy link

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The changes look safe to me, and it seems we're having the same behavior as the official VTL library for this. Good investigation and fix 🕵️

The changes to the tests/CI looks good too, I think we might be able to not install the test target instead of runtime (it's a lot more) but only add localstack-snapshot to the list of extra_requires in setup.py? Might be worth giving it a try 😄
I suppose we should switch it to pyproject.toml at some point soon.

Also, we should probably already bump the version in setup.py and update the changelog in the readme, if possible. Then, we're good to go! 🚀

@cloutierMat
Copy link
Author

I think we might be able to not install the test target instead of runtime (it's a lot more) but only add localstack-snapshot

Good idea, I will explore on that.

Also, we should probably already bump the version in setup.py and update the changelog in the readme, if possible. Then, we're good to go! 🚀

👍

@cloutierMat cloutierMat merged commit 3ca2d54 into master Oct 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants