Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This pr adds support string utility
matches
. The functionality itself was fairly straightforward but some changes toStringLiteral
were required to fully support regular expressions. Notably we were only allowing certain characters to be escaped in string literals, while aws accepts anything. No tests seemed to depend on the escaped character restriction, but it should be safer to run a full suite of localstack tests to ensure this does not create any unforeseen regressions.Since localstack has gone through a big code restructure since last time this code was change, I have had to update
conftest
and themain.yml
configuration to be inline with latest development