Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix putting nulls in maps #17

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Fix putting nulls in maps #17

merged 4 commits into from
Dec 12, 2023

Conversation

simonrw
Copy link

@simonrw simonrw commented Dec 8, 2023

Motivation

There is a template parsing error for null handling in situations like:

$myMap.put('key', null)

Changes

  • Handle null values in map.put
  • Bump meta information files

@simonrw simonrw self-assigned this Dec 8, 2023
@simonrw simonrw requested review from calvernaz and whummer December 8, 2023 17:14
whummer
whummer approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @simonrw ! LGTM 👍 Interesting again that Java VTL behaves differently than the AWS implementation.. :)

@simonrw simonrw merged commit 7aced14 into master Dec 12, 2023
1 check passed
@simonrw simonrw deleted the fix/nulls-in-maps branch December 12, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whummer whummer whummer approved these changes

@calvernaz calvernaz Awaiting requested review from calvernaz

Assignees

@simonrw simonrw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonrw @whummer