Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more appsync methods #16

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Add more appsync methods #16

merged 5 commits into from
Nov 14, 2023

Conversation

simonrw
Copy link

@simonrw simonrw commented Nov 14, 2023

Motivation

A few crucial string and array methods are missing from our AppSync implementation. These are:

  • Array.isEmpty
  • String.indexOf
  • String.substring

Changes

This PR adds these specific features

@simonrw simonrw self-assigned this Nov 14, 2023
@simonrw simonrw requested a review from whummer November 14, 2023 15:55
@simonrw simonrw marked this pull request as ready for review November 14, 2023 15:57
whummer
whummer approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - kudos for adding those here! 🚀

@simonrw simonrw merged commit 5d6bfef into master Nov 14, 2023
1 check passed
@simonrw simonrw deleted the fix/more-appsync-operators branch November 14, 2023 21:15
@simonrw simonrw mentioned this pull request Nov 16, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whummer whummer whummer approved these changes

Assignees

@simonrw simonrw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonrw @whummer