add contains and toString #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whummer
reviewed
Sep 17, 2023
There was a problem hiding this comment.
Nice! Thanks for adding this @calvernaz , and for adding the snapshot test. 🎉
Looks like there's only a small discrepancy - I guess we could create a custom serializer to convert dict objects to string.. (VTL uses the Java notation of Map.toString)
>> match key: render-result-1
(~) / '{k1=v1, k2=v2}' → "{'k1': 'v1', 'k2': 'v2'}" ... (expected → actual)
|
/
good catch, have a fix for it, hopefully is good enough |
whummer
approved these changes
Sep 17, 2023
calvernaz
force-pushed
the
contains-and-to_string-additional-methods
branch
from
d4020a7 to
fcb2b2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds toString and contains methods. These two have been overridden in community and will be removed once this is merged