Include localstack-core[runtime] in dev install target (#19)

localstack · Oct 26, 2024 · ee2e692 · ee2e692
1 parent 3ca2d54
commit ee2e692
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -33,10 +33,6 @@ jobs:
           sudo apt-get install -y libsasl2-dev
           make install
 
-          # Note: currently required to import snapshot utils from localstack
-          # TODO remove once imports are better organized in localstack
-          . .venv/bin/activate; pip install localstack-core[runtime]
-
       - name: Run tests
         run: |
           make lint

diff --git a/Makefile b/Makefile
@@ -14,6 +14,7 @@ install:           ## Install dependencies in local virtualenv folder
 
 publish:           ## Publish the library to the central PyPi repository
 	# build and upload archive
+	$(VENV_RUN); $(PIP_CMD) install twine
 	$(VENV_RUN); ./setup.py sdist && twine upload $(BUILD_DIR)/*.tar.gz
 
 test:              ## Run automated tests

diff --git a/setup.py b/setup.py
@@ -28,6 +28,7 @@
         "flake8",
         "flake8-black",
         "flake8-isort",
+        "localstack-core[runtime]",
         "pytest",
         "pytest-httpserver",
         "localstack-snapshot",