Feature: Add GitHub action workflow #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe4dev
requested changes
Mar 20, 2024
| schedule: | ||
| # “At 00:00 on Sunday.” | ||
| - cron: "0 0 * * 0" | ||
| workflow_dispatch: |
| LOCALSTACK_API_KEY: ${{ secrets.LOCALSTACK_API_KEY }} | ||
|
|
||
| - name: Deploy using CDK | ||
| run: | |
There was a problem hiding this comment.
Consider invoking the make targets here
There was a problem hiding this comment.
but that makes it a bit trickier to control the exit codes. Chaining with && \ instead of newlines would do it
| cdklocal deploy KinesisFirehoseRedshiftStack2 --require-approval never | ||
|
|
||
| - name: List the resources | ||
| run: | |
| awslocal redshift describe-clusters | ||
|
|
||
| - name: Run pytests | ||
| run: | |
maxhoheiser
force-pushed
the
feature/github-action
branch
from
88aa04b to
6b5bb4f
Compare
maxhoheiser
force-pushed
the
feature/github-action
branch
from
8dd4c6a to
d590f14
Compare
…ecking in .env file
maxhoheiser
had a problem deploying
to
default-env
GitHub Actions
Failure
maxhoheiser
had a problem deploying
to
default-env
GitHub Actions
Failure
HarshCasper
had a problem deploying
to
default-env
GitHub Actions
Failure
HarshCasper
force-pushed
the
feature/github-action
branch
from
140e98c to
819ef2f
Compare
HarshCasper
had a problem deploying
to
default-env
GitHub Actions
Failure
HarshCasper
force-pushed
the
feature/github-action
branch
from
819ef2f to
5f9c4da
Compare
Even if this exposes secrets and config variables, since they should only be mock variables used for local testing it is not a security risk. For production always use a github actions environment with secrets and variables.
HarshCasper
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a GitHub action workflow, that installs required dependencies, starts a Localstack container, deploys the infrastructure and runs the pytest