refactor(worker): cleanup worker error handling logic #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the inference error logic from the SAM2 pipeline to all pipelines so users are given a warning when they supply wrong arguments.
This commit ensures that users get a descriptive error message when the GPU runs out of memory.
This commit ensures that all response errors are known by FastAPI and therefore shown in the docs.
This commit adds some missing error handling to the pipeline worker functions.
This commit improves the error handling code so that it contains less redundancy.
This commite moves the handleJSONError to the global scope since it is used by each pipeline. This prvents code redundancy.
rickstaa
changed the title
rickstaa
commented
Sep 22, 2024
| @@ -219,34 +206,25 @@ func (w *Worker) Upscale(ctx context.Context, req UpscaleMultipartRequestBody) ( | |||
| return nil, err | |||
| } | |||
|
|
|||
| if resp.JSON422 != nil { | |||
| val, err := json.Marshal(resp.JSON422) | |||
There was a problem hiding this comment.
Check why this was used before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request restructures the worker error handling logic so that the code is a bit leaner.