Update AppKernel.php #114
Update AppKernel.php #114
Conversation
|
you need to update the testsuite to make it use the namespaced kernel though |
| */ | ||
| protected static function getKernelClass() | ||
| { | ||
| require_once __DIR__.'/../app/AppKernel.php'; |
There was a problem hiding this comment.
even better: configure the autoload_dev in composer.json to be able to autoload this class (I think it is even already able to do it), making this requiring useless
There was a problem hiding this comment.
I think it is even already able to do it
Seems to be true.
|
My local tests passed: Test fails at travis in PHP 5.3 🤔 , seems to be the same behavior in master? |
|
@liuggio review please |
|
@Aliance thanks a lot! the problem is on “[“ on <5.4 PHP version :( |
|
@liuggio did you have enough time to watch out the problem? |
|
@liuggio hello. Sorry for being annoying but may be merge this pr? |
|
Sorry for the delay but this needs a major version, and this is not a killer feature :( |
|
@liuggio any news? |
|
@liuggio why does it need a major version ? This changes a class in the testsuite fixtures. This class is not autoloadable when using the bundle in projects. |
Without namespace IDE throws an error of duplicated class:
