Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 使用qt播放器播放ape文件 #492

Open
wants to merge 1 commit into
base: release/eagle
Choose a base branch
from

Conversation

myk1343
Copy link
Contributor

@myk1343 myk1343 commented Sep 29, 2024

使用qt播放器播放ape文件

Bug: https://pms.uniontech.com/bug-view-275987.html
Log: 使用qt播放器播放ape文件

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myk1343

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

使用qt播放器播放ape文件

Bug: https://pms.uniontech.com/bug-view-275987.html
Log: 使用qt播放器播放ape文件
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • VlcPlayer::setQtPlayer函数中,应该检查传入的qtPlayer是否为nullptr,以避免潜在的空指针解引用错误。
  • VlcPlayer::play函数中,应该检查m_bApe的值,以决定是否调用m_qtPlayerplay方法。
  • VlcPlayer::pauseVlcPlayer::resumeVlcPlayer::stop函数中,应该检查m_bApe的值,以决定是否调用m_qtPlayer的相应方法。
  • VlcPlayer::setMediaMeta函数中,应该检查MetaDetector::getInstance()->getAudioType(meta).toLower()的返回值是否为"ape",以决定是否设置m_bApe的值。
  • VlcPlayer::setVolumeVlcPlayer::setMute函数中,应该检查m_bApe的值,以决定是否调用m_qtPlayer的相应方法。
  • VlcPlayer::getMute函数中,应该检查m_bApe的值,以决定是否调用m_qtPlayergetMute方法。

是否建议立即修改:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants