Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: Remove Thumbnailer dependency (#473)" #476

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Revert "fix: Remove Thumbnailer dependency (#473)" #476

merged 1 commit into from
Jun 12, 2024

Conversation

myk1343
Copy link
Contributor

@myk1343 myk1343 commented Jun 12, 2024

This reverts commit bd46423.

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • initThumb函数中,返回类型从bool更改为void,但没有提供新的实现逻辑或文档说明。这可能会导致调用该函数的代码出现问题,因为它不再返回布尔值。
  • Platform_ThumbnailWorkerThumbnailWorker类中,initThumb函数的实现被移除,但仍然在类中声明。这可能会导致编译错误或混淆,因为该函数不再被实现。
  • Platform_viewProgBarLoad类中,initThumb函数的实现被更改为void类型,但没有提供新的实现逻辑或文档说明。这可能会导致调用该函数的代码出现问题,因为它不再具有预期的行为。

是否建议立即修改:

  • 需要提供对initThumb函数返回类型更改的文档说明,以确保调用者了解新的行为。
  • 应该恢复Platform_ThumbnailWorkerThumbnailWorker类中initThumb函数的实现,或者如果确实不再需要,则将其从类中移除。
  • Platform_viewProgBarLoad类中,应该恢复initThumb函数的实现,或者如果确实不再需要,则将其从类中移除。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myk1343, pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@myk1343 myk1343 merged commit 048aca8 into linuxdeepin:project/icbc Jun 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants