Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add libdmr settings binding method #475

Closed
wants to merge 1 commit into from

Conversation

pengfeixx
Copy link
Contributor

Bind through property settings window

Log: Bind through property settings window

Bind through property settings window

Log: Bind through property settings window
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • MpvProxy::MpvProxy构造函数中,新增的代码检查了父窗口的"composited"属性,并将其设置为false。这可能是一个错误,因为通常属性应该是可读的,而不是可写的。
  • PlayerWidget构造函数中,新增的代码检查了父窗口的"composited"属性,并将其设置为false。这可能是一个错误,因为通常属性应该是可读的,而不是可写的。
  • PlayerEngine的构造函数中,新增的代码检查了父窗口的"composited"属性,并将其设置为false。这可能是一个错误,因为通常属性应该是可读的,而不是可写的。

是否建议立即修改:

Copy link
Contributor

@rb-union rb-union left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@jeffshuai
Copy link

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@pengfeixx pengfeixx closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants