Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [review] When the sidebar content is fully displayed, only the vertical scroll wheel is used #262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

starhcq
Copy link
Contributor

@starhcq starhcq commented Sep 27, 2024

1.When the sidebar content is fully displayed, only the vertical scroll wheel is used;
2.Adjust Image show style.

Log: When the sidebar content is fully displayed, only the vertical scroll wheel is used

…ertical scroll wheel is used

   1.When the sidebar content is fully displayed, only the vertical scroll wheel is used;
   2.Adjust Image show style.

Log: When the sidebar content is fully displayed, only the vertical scroll wheel is used
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • ThumbnailListDelegate.qml中,DropShadow组件的属性被修改,可能会影响遮罩效果。需要确认这些属性的更改是否符合设计要求。
  • Sidebar.qml中,wheelEnabled的逻辑判断条件从false修改为column.height > sidebarScrollView.height,这可能会改变滚动事件的处理方式。需要验证这个改动是否符合预期行为。
  • HaveImportedView.qml中,onFilterTypeChanged事件的处理逻辑被修改,增加了对GStatus.loading的检查。这个改动可能是为了阻止在加载数据时更新视图,但需要确保这个改动不会影响用户体验。

是否建议立即修改:

  • 是,需要确保这些更改不会对现有功能产生负面影响,并且与产品设计规范相符合。如果这些更改是故意的,应该在代码中添加相应的注释来解释为什么这样修改。

@myk1343
Copy link

myk1343 commented Sep 29, 2024

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants