Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve the issue of the probability of crashing when switching to an imported view #258

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

starhcq
Copy link
Contributor

@starhcq starhcq commented Sep 23, 2024

Resolve the issue of the probability of crashing when switching to an imported view

Log: Resolve the issue of the probability of crashing when switching to an imported view
Bug: https://pms.uniontech.com/bug-view-271803.html

…to an imported view

  Resolve the issue of the probability of crashing when switching to an imported view

Log: Resolve the issue of the probability of crashing when switching to an imported view
Bug: https://pms.uniontech.com/bug-view-271803.html
@starhcq starhcq changed the title fix: Resolve the issue of organic crashes when switching to imported views Resolve the issue of the probability of crashing when switching to an imported view Sep 23, 2024
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • Sidebar.qml文件中添加了wheelEnabled: false属性,可能影响用户交互,需要确认是否符合设计需求。
  • HaveImportedView.qml文件中,增加了show条件判断并启动动画,可能影响用户体验,需要确保动画效果符合设计要求。
  • 移除了onShowChanged信号处理函数,如果其他组件依赖于show信号进行动画控制,可能会导致问题。

是否建议立即修改:

  • 是,需要确认wheelEnabled: false的添加是否符合用户体验设计,并确保动画效果的正确实现。同时,需要检查是否有其他组件依赖于show信号,以确保组件的兼容性和稳定性。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pengfeixx, rb-union, starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@starhcq starhcq merged commit fb8c9e7 into linuxdeepin:master Sep 23, 2024
15 of 17 checks passed
@@ -16,6 +16,7 @@ import "../"
ScrollView {
id: sidebarScrollView
clip: true
wheelEnabled: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

考虑较多条目时,需要滚动展示的场景。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改,在显示内容不全时,才激活垂直滚轮

@@ -38,8 +38,11 @@ BaseView {
}

onVisibleChanged: {
if (visible && !GStatus.backingToMainAlbumView)
if (visible && !GStatus.backingToMainAlbumView) {
flushHaveImportedView()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

验证下低性能机器,是否还有问题

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

暂无问题。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants