Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve the issue of not hiding image operation buttons after deleting all images #224

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

starhcq
Copy link
Contributor

@starhcq starhcq commented Jul 25, 2024

1.Resolve the issue of not hiding image operation buttons after deleting all images
2.fix titlebar left area has shadow‘s problem

Log: Resolve the issue of not hiding image operation buttons after deleting all images
Bug: https://pms.uniontech.com/bug-view-168547.html

…leting all images

      1.Resolve the issue of not hiding image operation buttons after deleting all images
      2.fix titlebar left area has shadow‘s problem

Log: Resolve the issue of not hiding image operation buttons after deleting all images
Bug: https://pms.uniontech.com/bug-view-168547.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • TitleBar的QML文件中,使用了title.width > GStatus.needHideSideBarWidth来判断左侧间距的大小,这可能是一个逻辑错误,因为title.width可能小于GStatus.needHideSideBarWidth
  • ThumbnailListViewTools.js文件中,调用thumbnailModel.clearSelection()时没有检查thumnailListType是否等于Album.Types.ThumbnailTrash,这可能会导致在删除时没有正确清除选择。
  • HaveImportedView.qml文件中,将visible属性设置为false可能会影响用户界面,需要确认这是否是预期的行为。

是否建议立即修改:

  • 需要立即修正逻辑错误,以避免潜在的界面问题。
  • 需要检查ThumbnailListViewTools.js中的删除逻辑,确保删除操作正确执行。
  • 需要确认HaveImportedView.qml中隐藏视图的决策是否符合产品需求。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pengfeixx, starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@starhcq starhcq merged commit 025103d into linuxdeepin:master Jul 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants