Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [UI] Modify pop-up window style #216

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

starhcq
Copy link
Contributor

@starhcq starhcq commented Jul 22, 2024

Modify pop-up window style, include delete photo and create album

Log: [UI] Modify pop-up window style
Bug: https://pms.uniontech.com/bug-view-193023.html, https://pms.uniontech.com/bug-view-168193.html

   Modify pop-up window style, include delete photo and create album

Log: [UI] Modify pop-up window style
Bug: https://pms.uniontech.com/bug-view-193023.html, https://pms.uniontech.com/bug-view-168193.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在DeleteDialog.qml中,最小高度和最大高度的修改可能影响窗口的布局和显示。需要确认是否有必要修改,以及修改后的效果是否符合设计要求。
  • 在DeleteDialog.qml中,字体大小从16像素修改为5像素,需要确认这是否是预期的更改,以及更改后的字体大小是否合适。
  • 在NewAlbumDialog.qml中,Label组件的字体大小从14像素修改为36像素,这可能影响文本的显示和布局。需要确认这是否是预期的更改,以及更改后的字体大小是否合适。
  • 在NewAlbumDialog.qml中,Button组件的字体大小从16像素修改为6像素,这可能影响文本的显示和布局。需要确认这是否是预期的更改,以及更改后的字体大小是否合适。
  • 在RemoveAlbumDialog.qml中,最小高度和最大高度的修改可能影响窗口的布局和显示。需要确认是否有必要修改,以及修改后的效果是否符合设计要求。
  • 在RemoveAlbumDialog.qml中,字体大小从16像素修改为14像素,这可能影响文本的显示和布局。需要确认这是否是预期的更改,以及更改后的字体大小是否合适。

是否建议立即修改:

  • 是,需要确保所有更改都是经过设计团队批准的,并且不会对窗口的布局和显示产生负面影响。同时,应该检查这些更改是否影响了用户界面的一致性和可用性。

@starhcq
Copy link
Contributor Author

starhcq commented Jul 22, 2024

/review @rb-union

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rb-union, starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@starhcq starhcq merged commit 4423fe7 into linuxdeepin:master Jul 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants