Add support for SSH credentials from memory. #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was actually thinking about that recently. It would make sense to expose this as a feature. |
|
Okay. I'll see if I can hack this up, until then this PR will have to wait a bit. 😄 |
|
will it be merged? I owuld use this feature as well. |
|
@arthurschreiber anything I can do to assist with getting this merged? happy to help contribute to rugged or libgit2 if needed |
|
@carlosmn Any reason this was never added/addressed ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build is currently failing because SSH memory credential support is not listed as part of
Rugged.features.@carlosmn Would a patch to libgit2 to add something like
GIT_FEATURE_SSH_KEY_FROM_MEMORYbe accepted?