Angular to js #455
Closed
Angular to js #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added some modifications to review. It includes code cleaning by separating the JavaScript from the Twig file. I also fixed the empty return when filtering on translations, so it displays the same as translationsUnits. |
shadowalkerCode-007
force-pushed
the
angular-to-Js
branch
from
37781ad
to
bffd9c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
To continue the discussions in this open ticket #454
This is my version, of migrating the bundle from old Angular to pure JavaScript, to review.
I tested it with my Symfony 6.4 project and its working fine.
If anything is missing, please let me know.