Fix #create_or_update_student #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❓ @grmnlrt is the uid different for the 21 records created at the account level? |
|
@Eschults Yes, the uid is each time different |
|
👌 |
|
Could you Also it would be nice to add a |
|
@Eschults not sure to understand what you mean with the |
|
Let's write one as we did for lewagon/linkedin-extension and lewagon/kitt to actually create git releases and bump the version of the gem when we "publish" a set of changes merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Received the following response from Edusign CTO about my question related to student duplicates:
After investigations, I think we should always try to find a student with they uid and with they email if not found with the uid. WDYT?