Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace kinpy by optas #53

Merged
merged 6 commits into from
Aug 5, 2023
Merged

Replace kinpy by optas #53

merged 6 commits into from
Aug 5, 2023

Conversation

mhubii
Copy link
Member

@mhubii mhubii commented Feb 8, 2023

Refer to #42

@mhubii
Copy link
Member Author

mhubii commented May 9, 2023

I'll try to merge these changes into all branches next!

@mhubii
Copy link
Member Author

mhubii commented May 9, 2023

I merged the foxy changes into dev-foxy-optas.

is this PR still conform with the optas API? ie here https://github.com/KCL-BMEIS/lbr_fri_ros2_stack/pull/53/files

sorry for the delay

@cmower

Copy link
Member

@cmower cmower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, but otherwise looks good!

Copy link
Member Author

@mhubii mhubii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legit

@mhubii mhubii merged commit e37345c into foxy Aug 5, 2023
2 checks passed
@mhubii mhubii deleted the dev-foxy-optas branch August 5, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants