State Interface Fix FRI >= 2 #183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes made to the local branch for FRI3 compatibility
mhubii
commented
May 29, 2024
lbr_moveit_config/med7_moveit_config/config/moveit_controllers.yaml
Outdated
Show resolved
Hide resolved
lbr_moveit_config/med7_moveit_config/launch/move_group.launch.py
Outdated
Show resolved
Hide resolved
mhubii
commented
May 30, 2024
mhubii
commented
May 30, 2024
| @@ -1,4 +1,8 @@ | |||
| # these parameters are read by the lbr_system_interface.xacro and configure the lbr_ros2_control::SystemInterface | |||
| fri_client_version: # FRI client version is used to determine required interfaces in lbr_system_interface.xacro | |||
There was a problem hiding this comment.
is the user required to configure this, or can this be done automatically?
At least there should be a runtime error hinting to a potential mismatch.
|
closing this PR as contributions might vanish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #182
Fixes #181