Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set branch coverage to false #1313

Merged
merged 2 commits into from
Sep 8, 2024
Merged

Set branch coverage to false #1313

merged 2 commits into from
Sep 8, 2024

Conversation

drc38
Copy link
Collaborator

@drc38 drc38 commented Sep 8, 2024

@lbbrhzn I don't think branch testing is working properly with the asyncio tests

@drc38 drc38 temporarily deployed to continuous-integration September 8, 2024 08:23 — with GitHub Actions Inactive
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.31%. Comparing base (a268a86) to head (b1db75b).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1313      +/-   ##
==========================================
+ Coverage   91.27%   95.31%   +4.03%     
==========================================
  Files           9        9              
  Lines        1387     1387              
  Branches      222        0     -222     
==========================================
+ Hits         1266     1322      +56     
  Misses         65       65              
+ Partials       56        0      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drc38 drc38 temporarily deployed to continuous-integration September 8, 2024 08:28 — with GitHub Actions Inactive
@drc38 drc38 requested a review from lbbrhzn September 8, 2024 08:31
@lbbrhzn
Copy link
Owner

lbbrhzn commented Sep 8, 2024

Why disable branch coverage? It would mean you only get coverage info after merging to main. I think we should look at coverage before merging to main.

@drc38
Copy link
Collaborator Author

drc38 commented Sep 8, 2024

Why disable branch coverage? It would mean you only get coverage info after merging to main. I think we should look at coverage before merging to main.

It does not relate to branches in Github but rather branching code eg an if statement. See https://coverage.readthedocs.io/en/latest/branch.html#branch

Where we test different parts of an if statement in separate async calls this appears to result in lots of partial coverage lines, which aren't in reality.

This was highlighted by #1300

@lbbrhzn
Copy link
Owner

lbbrhzn commented Sep 8, 2024

ok, then it's fine.

@lbbrhzn lbbrhzn merged commit 4b06be7 into main Sep 8, 2024
8 checks passed
@lbbrhzn lbbrhzn deleted the cov branch September 8, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants