animation div sticky correction #6130
Merged
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: balagowda <[email protected]>
|
🚀 Preview for commit 9d62e6b at: https://67694a5916d269264ab11c3b--layer5.netlify.app |
sudhanshutech
requested changes
Dec 25, 2024
| @@ -1,7 +1,7 @@ | |||
| import styled from "styled-components"; | |||
|
|
|||
| const NavigationWrap = styled.header` | |||
| position: sticky; | |||
| // position: sticky; | |||
There was a problem hiding this comment.
remove it if not needed, don't keep it as comment
| @@ -71,6 +71,7 @@ h2 { | |||
| } | |||
| .diagram { | |||
| margin-bottom:150px; | |||
There was a problem hiding this comment.
@sudhanshutech Left div will go to the end of the parent div, compared to the right div, which looks bad. So, I added a margin there.
There was a problem hiding this comment.
You can see the left div reaching the end.
There was a problem hiding this comment.
And this is after adding margin
src/sections/app.style.js
Outdated
| @@ -64,7 +64,7 @@ body { | |||
| transition-timing-function: cubic-bezier(0.2, 0.8, 0.2, 1); | |||
| font-family: "Qanelas Soft", "Open Sans", sans-serif; | |||
| overflow-x: hidden !important; | |||
| // overflow-x: hidden !important; | |||
|
@balagowda incorporate the feedback and rest looks good.✔️ |
Signed-off-by: balagowda <[email protected]>
|
🚀 Preview for commit 1bbfd03 at: https://676ba93eda0e8ed49751fc4a--layer5.netlify.app |
sudhanshutech
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #5985
Untitled.mov
Notes for Reviewers
Signed commits