Add toggle-button component #6127
Conversation
Signed-off-by: eyeaadil <[email protected]>
eyeaadil
force-pushed
the
add-toggle-button-component
branch
from
bb056ec to
fe4e389
Compare
|
🚀 Preview for commit fe4e389 at: https://6764364266069e46100ebd59--layer5.netlify.app |
|
@l5io ,can you please review this PR? |
gatsby-node.js
Outdated
| @@ -728,6 +728,9 @@ exports.createPages = async ({ actions, graphql, reporter }) => { | |||
|
|
|||
| const components = componentsData.map((component) => component.src.replace("/", "")); | |||
|
|
|||
|
|
|||
| console.log("Adilllllllllll",components); | |||
|
|
|||
There was a problem hiding this comment.
Why are there logs? You should remove all of them.
Signed-off-by: eyeaadil <[email protected]>
|
🚀 Preview for commit 1f86b76 at: https://6764e31e62c055bf7dc6cd61--layer5.netlify.app |
Signed-off-by: eyeaadil <[email protected]>
|
🚀 Preview for commit ee92d60 at: https://6764ee9243e3a0d6fe4821ce--layer5.netlify.app |
|
@Vidit-Kushwaha ,can you please review this? |
|
@eyeaadil still I can see changes in package.json and gatsby-node.js |
|
@eyeaadil Please add it as an agenda item to the meeting minutes. |
There was a problem hiding this comment.
Revert changeous in this file
package-lock.json
Outdated
There was a problem hiding this comment.
Button name is not intuitive can we change button name from Bold, Underline, and italic to another name like toogle button 1
| @@ -19,7 +19,7 @@ const componentsData = [ | |||
| id: 3, | |||
| name: "Modal", | |||
| description: | |||
| "A text input is made up of multiple elements that combine to form a component that helps users to read, write, and edit text in an interface.", | |||
There was a problem hiding this comment.
Can you revert changes to original for Modal object?
There was a problem hiding this comment.
@eyeaadil I have added a few comments. You can look into it
|
🚀 Preview for commit 787218b at: https://676cd9847770b4210ed2db12--layer5.netlify.app |
Description
This PR fixes #5958
Notes for Reviewers
For complete changes check the given link
https://6764ee9243e3a0d6fe4821ce--layer5.netlify.app/projects/sistent/components/toggle-button/guidance
ScreenShot
Signed commits