made padding consistent by adding h3 class to ProgramGrid component and using that instead of passing a subtitle prop for the subtitle #6087
Conversation
Signed-off-by: faatima_abidi <[email protected]>
|
🚀 Preview for commit a199d8c at: https://673e79cfa111e9a3ab9a2501--layer5.netlify.app |
|
@FaatimaAbidi adding it as an agenda item to the meeting minutes. |
| @@ -57,7 +57,8 @@ const ProgramsGrid = ({ hide_path, sub_section }) => { | |||
|
|
|||
| return ( | |||
| <ProgramsPageWrapper> | |||
| <PageHeader title="Open Source Internship Programs" subtitle="Build Your Career at Layer5" path={path} /> | |||
There was a problem hiding this comment.
is this pageheader used elsewhere also, i guess yes. So why only here the subtitle having the css issues and not elsewhere?
There was a problem hiding this comment.
yes, the pageHeader is used in other components too, and the subtitle has css issues in those places as well. For example, the issue exists on this page as well: https://layer5.io/community/members
There was a problem hiding this comment.
@sudhanshutech instead of the fix I did for the current page, should I fix the issue for all pages by adding the h3 class to the page header subtitle component?
There was a problem hiding this comment.
@FaatimaAbidi It should be for all page headings. You can add to components
|
@FaatimaAbidi any update? |
|
Yes @sudhanshutech, I am almost done making the changes that @Vidit-Kushwaha suggested so I'll be updating my PR shortly. |
FaatimaAbidi
force-pushed
the
fix_for_headers
branch
from
a199d8c to
3ae44a9
Compare
…fixed the header margin issue on the open source internship programs page. Signed-off-by: faatima_abidi <[email protected]>
FaatimaAbidi
force-pushed
the
fix_for_headers
branch
from
3ae44a9 to
860d443
Compare
|
🚀 Preview for commit 860d443 at: https://6763a56eb16ae3073b5b769d--layer5.netlify.app |
Description
This PR fixes #5648
Notes for Reviewers
Signed commits