Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the avatar section #6021

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

NishantSinghhhhh
Copy link
Contributor

Description

Component Name: Avatar component present in Sistent component folder.

This PR addresses various enhancements and features, including:

  • Documentation: I have written documentation for the Avatar Component used in the Sistent repository.
  • Avatar Variants: Added different styles for avatars, including square, rounded, and customizable sizes to enhance user experience.
  • Security Practices: Documented best practices for using avatars with proper alt text for accessibility.

Notes for Reviewers

Please pay special attention to the documentation and feedback on these changes would be greatly appreciated.

Signed commits

Yes, I signed my commits.

Signed-off-by: NishantSinghhhhh <[email protected]>
@github-actions github-actions bot added area/projects An issue relating to Layer5 initiatives (projects) project/sistent labels Oct 22, 2024
@l5io
Copy link
Contributor

l5io commented Oct 22, 2024

🚀 Preview for commit e8c9fa5 at: https://67179cd4a8981b0c7b1ae4b8--layer5.netlify.app

@nebula-aac nebula-aac self-requested a review October 22, 2024 18:44
@l5io
Copy link
Contributor

l5io commented Oct 22, 2024

🚀 Preview for commit 20d6f1c at: https://67180066d051d5b1630ff7d3--layer5.netlify.app

@NishantSinghhhhh
Copy link
Contributor Author

@sudhanshutech sir can you review it and merge this PR if possible

@l5io
Copy link
Contributor

l5io commented Oct 23, 2024

🚀 Preview for commit f006e13 at: https://6719002053ba8600eaf9bdac--layer5.netlify.app

@NishantSinghhhhh
Copy link
Contributor Author

Are there any other changes required that makes my code suitable to merge it in the main branch

@l5io
Copy link
Contributor

l5io commented Oct 23, 2024

🚀 Preview for commit 2352ed6 at: https://671925300d8a2b3794faef38--layer5.netlify.app

@NishantSinghhhhh
Copy link
Contributor Author

@nebula-aac , I have resolved conflicts from this branch too ! :-)

@l5io
Copy link
Contributor

l5io commented Oct 24, 2024

🚀 Preview for commit bc1f486 at: https://671a52512aedc81ce200b984--layer5.netlify.app

Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NishantSinghhhhh would you please use some other characters for avatar like any cartoon characters instead our people. It would be also good if you can use any existing images already there

@NishantSinghhhhh
Copy link
Contributor Author

@NishantSinghhhhh would you please use some other characters for avatar like any cartoon characters instead our people. It would be also good if you can use any existing images already there

Sir Can I find Cartoon images in the layer5 folder ??

@sudhanshutech
Copy link
Member

@NishantSinghhhhh you can use the five images. It should be in layer5 repo only or you will get from layer5 brand page

@NishantSinghhhhh
Copy link
Contributor Author

NishantSinghhhhh commented Oct 24, 2024

@NishantSinghhhhh you can use the five images. It should be in layer5 repo only or you will get from layer5 brand page

sir can you please provide the link if possible

@sudhanshutech
Copy link
Member

https://layer5.io/company/brand

@l5io
Copy link
Contributor

l5io commented Oct 24, 2024

🚀 Preview for commit 4c378f5 at: https://671a7e0eb4c16313edc28ba9--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Oct 24, 2024

🚀 Preview for commit adc7e43 at: https://671a8672b4c1632114c28fe2--layer5.netlify.app

@leecalcote
Copy link
Member

Cool. Thank you, @NishantSinghhhhh and @nebula-aac 🙌

@NishantSinghhhhh
Copy link
Contributor Author

Cool. Thank you, @NishantSinghhhhh and @nebula-aac 🙌

Pleasure Sir

@NishantSinghhhhh
Copy link
Contributor Author

@sudhanshutech , sir can you have a look at this PR once again

@l5io
Copy link
Contributor

l5io commented Oct 27, 2024

🚀 Preview for commit 1b7c376 at: https://671dfa5adecd37137335b6ef--layer5.netlify.app

@vishalvivekm
Copy link
Contributor

@NishantSinghhhhh
Thank you for your contribution!
Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

Please add it as an agenda item to the meeting minutes.

@l5io
Copy link
Contributor

l5io commented Oct 30, 2024

🚀 Preview for commit 6beebac at: https://672225348e16a69496197562--layer5.netlify.app

@sudhanshutech
Copy link
Member

@vishalvivekm did you pointed @NishantSinghhhhh to those svgs we talked about in call?

@leecalcote
Copy link
Member

@vishalvivekm did you pointed @NishantSinghhhhh to those svgs we talked about in call?

@NishantSinghhhhh will you be completing this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/projects An issue relating to Layer5 initiatives (projects) project/sistent
Development

Successfully merging this pull request may close these issues.

6 participants