Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stash): release package to npm #3184

Merged
merged 8 commits into from
Sep 19, 2024
Merged

feat(stash): release package to npm #3184

merged 8 commits into from
Sep 19, 2024

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Sep 17, 2024

doing this now so we can build on it, even though its still not stabilized

Copy link

changeset-bot bot commented Sep 17, 2024

🦋 Changeset detected

Latest commit: 811644e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@latticexyz/stash Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/cli Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/dev-tools Patch
@latticexyz/explorer Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world-module-metadata Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch
mock-game-contracts Patch
ts-benchmarks Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic
Copy link
Member

holic commented Sep 17, 2024

  • CreateStoreResult -> CreateStashResult or maybe ExtendedStash
  • getRecord doesn't account for namespace/table not existing, can runtime error
  • getRecord, getTable should return | undefined
    • turn on noUncheckedIndexedAccess tsconfig to help with this
  • getRecord (or perhaps in a useRecord hook), accept a strongly typed defaultValue for when the record doesn't exist (more ergonomic than ?? { ... } as const satisfies TableRecord<...>)
  • no helpers to access State from stash.get() with dynamically registered tables, using keys is awkward
  • see if record value for enums could return a strongly typed value (e.g. 0 | 1 | 2 instead of number)
  • some way to clear the stash
  • some method to clear the stash
  • not being able to get a table by its tableId is annoying during sync, need to carry around original MUD config to map tableId to table label and namespaceLabel
  • clarify usages of namespace label with namespaceLabel
  • getConfig -> getTableConfig

edit: moved to #3200

@holic holic changed the title chore(stash): release package to npm feat(stash): release package to npm Sep 19, 2024
@holic holic merged commit 20fac30 into main Sep 19, 2024
14 checks passed
@holic holic deleted the stash branch September 19, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants