Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stash follow ups #3200

Open
1 of 12 tasks
holic opened this issue Sep 19, 2024 · 0 comments
Open
1 of 12 tasks

stash follow ups #3200

holic opened this issue Sep 19, 2024 · 0 comments

Comments

@holic
Copy link
Member

holic commented Sep 19, 2024

  • CreateStoreResult -> CreateStashResult or maybe ExtendedStash
  • getRecord doesn't account for namespace/table not existing, can runtime error
  • getRecord, getTable should return | undefined
    • turn on noUncheckedIndexedAccess tsconfig to help with this
  • getRecord (or perhaps in a useRecord hook), accept a strongly typed defaultValue for when the record doesn't exist (more ergonomic than ?? { ... } as const satisfies TableRecord<...>)
  • no helpers to access State from stash.get() with dynamically registered tables, using keys is awkward
  • see if record value for enums could return a strongly typed value (e.g. 0 | 1 | 2 instead of number)
  • some way to clear the stash
  • some method to clear the stash
  • not being able to get a table by its tableId is annoying during sync, need to carry around original MUD config to map tableId to table label and namespaceLabel
  • clarify usages of namespace label with namespaceLabel
  • getConfig -> getTableConfig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant