Rollback existing transactions after request ended #912
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP PDO transactions
Since Octane never actually quits, the transaction will still exist after the request has ended.
Consider the following code:
If for some reason someCondition() is true, the request is aborted, but the transaction is not ended.
If the user tries again and someCondition() is false, then both the new and previous 'User' model is created.
Fixes
#909
Unfortunately I don't know how to test this. Hopefully someone will add it.