[2.x] add missing host for http option #775
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jubeki
changed the title
|
@Jubeki can you elaborate on why you think this fix is necessary? |
|
Okay, my wording was a bad choice. I am not sure if it is a fix, but for me it is missing the host option, and I would assume that if you specify another host for some reason, it would be missing with the http option. If you already have the host available, why not use it there too. |
Jubeki
changed the title
|
I see. In fact, we made this change because typically, in an non-http scenarios, you don't want Caddy to validate the host. E.g: using NGINX proxy features, or even locally using a different domain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.