CalcMassFlux and CalculateMassAccretionRate ported to sparse packs #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yurlungur
requested changes
Mar 15, 2024
src/analysis/history_utils.hpp
Outdated
| const int b, const int k, const int j, | ||
| const int i) { | ||
| template <typename Geometry> | ||
| KOKKOS_INLINE_FUNCTION Real CalcMassFlux(MeshData<Real> *md, Geometry &geom, const int b, |
There was a problem hiding this comment.
This is not going to work on device. You still need to pass in the pack. But you probably don't need to pass in prho, pvel_lo or pvel_hi anymore, as you can simply use the types inside the pack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
CalcMassFlux and CalculateMassAccretionRate ported to sparse packs
PR Checklist
scripts/bash/format.sh.