Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outputs for SN postprocessing: max density, M_gain, and Qdot_gain #205

Merged
merged 9 commits into from
Mar 13, 2024

Conversation

mari2895
Copy link
Collaborator

@mari2895 mari2895 commented Mar 11, 2024

PR Summary

Created a reducer that only integrates in the gain region. Added the following outputs in history file: max density (central density, mass_gain and total net neutrino heating in the gain region).

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by calling scripts/bash/format.sh.
  • Explain what you did.

@mari2895 mari2895 self-assigned this Mar 11, 2024
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mari2895 this looks good, but I think it needs some revision. Please let me know if you're confused by any of the blow comments.

src/analysis/history.cpp Show resolved Hide resolved
src/analysis/history.hpp Show resolved Hide resolved
src/analysis/history.hpp Outdated Show resolved Hide resolved
src/analysis/history.hpp Outdated Show resolved Hide resolved
src/analysis/history.hpp Outdated Show resolved Hide resolved
src/analysis/history.hpp Show resolved Hide resolved
src/fluid/fluid.cpp Outdated Show resolved Hide resolved
src/fluid/fluid.cpp Outdated Show resolved Hide resolved
src/fluid/fluid.cpp Outdated Show resolved Hide resolved
src/fluid/fluid.cpp Outdated Show resolved Hide resolved
@Yurlungur Yurlungur mentioned this pull request Mar 12, 2024
3 tasks
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just two more nitpicks...

src/analysis/history.hpp Outdated Show resolved Hide resolved
@@ -207,6 +208,7 @@ std::shared_ptr<StateDescriptor> Initialize(ParameterInput *pin) {
physics->AddField(p::entropy::name(), mprim_scalar);
physics->AddField(p::cs::name(), mprim_scalar);
physics->AddField(diag::ratio_divv_cs::name(), mprim_scalar);
physics->AddField(diag::localization_function::name(), mprim_scalar);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're not using the localization function right? Let's comment this out for now and only add it when we need it.

@Yurlungur Yurlungur merged commit f877cdf into main Mar 13, 2024
2 checks passed
@Yurlungur Yurlungur deleted the mg/hst_outputs1 branch March 13, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants