Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify Cmake path to be independent of compile dir #186

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

modify Cmake path to be independent of compile dir #186

wants to merge 1 commit into from

Conversation

carlnotsagan
Copy link
Collaborator

typo in relative path for Cmake file variant patch

@Yurlungur
Copy link
Collaborator

This is not a typo---it depends on where you call cmake. However what's in there currently is a hack---there's a more robust way to do this, which I will try to thread through.

@carlnotsagan carlnotsagan changed the title fix typo in relative path of Cmake modify Cmake path to be independent of compile dir Nov 16, 2023
@carlnotsagan
Copy link
Collaborator Author

ok, makes sense, ive changed the title of the pr to reflect that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahm-LANL jonahm-LANL Awaiting requested review from jonahm-LANL

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlnotsagan @Yurlungur