-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add pagination on folders #4020
Open
Cristhianzl
wants to merge
95
commits into
main
Choose a base branch
from
cz/pagination-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+858
−321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⬆️ (uv.lock): Update httpx version from 0.27.2 to 0.27.0 ⬆️ (uv.lock): Add new package grpcio-health-checking version 1.62.3 ⬆️ (uv.lock): upgrade weaviate-client package from version 3.26.7 to 4.8.1 and add new dependencies grpcio, grpcio-health-checking, grpcio-tools, httpx, and pydantic. Update package source and distribution URLs accordingly.
…o improve performance and user experience 📝 (flows.py): Update documentation to reflect changes made for pagination and additional query parameters 📝 (folders.py): Add a new endpoint to retrieve a folder with paginated flows for better organization and readability
…w responses in API calls
…et_all" parameter to the request 🐛 (test_database.py): fix endpoint for fetching read-only starter projects to use correct URL path
…constants for default values and improve code readability 🐛 (paginatorComponent/index.tsx): fix issue with setting maxPageIndex when pages prop is provided to PaginatorComponent
… overflow and improve layout aesthetics
… settings, and store pagination settings to enhance user experience and improve functionality
… enable refetching queries on mutation settled state 📝 (use-post-login-user.ts): update useLoginUser function to include onSettled callback in options to refetch queries after mutation settles
…h basic examples of flows from the API and update the state with the fetched data.
…d process flows with query parameters for components_only, get_all, folder_id, remove_example_flows, page, and size. This allows for more flexible and specific retrieval of flow data.
…ns in the useGetFolderQuery function to enhance flexibility and customization for fetching folder data.
…d setStarterProjectId to improve code readability and maintainability ✨ (use-get-folders.ts): Update useGetFoldersQuery to setFolders with the fetched data instead of filtering out starter projects to simplify the logic and improve performance
…an object with get_all property set to true to fetch all flows when refreshing
… to clean up code and improve readability
… use constants for better maintainability 📝 (AdminPage/index.tsx): Update resetFilter function to set page size and index using constants for consistency 📝 (AdminPage/index.tsx): Update logic to handle loading state and empty user list based on isIdle state for better user experience 📝 (AdminPage/index.tsx): Update PaginatorComponent props to use constant for rows count and simplify paginate function assignment
…les and folders data for improved functionality and user experience
…a parameter to get all flows at once for better performance.
…ons to manage pagination for flows in the UtilityStoreType
…FoldersStoreType to manage folder data efficiently
…ation data in frontend application
…w data structure in the application.
… to allow customization of the number of pages displayed in the paginator
…lues for page and size to manage pagination in the utility store
…on 'setFolders' to manage folder data in the store
…a parameter to get all flows at once, improving efficiency and reducing unnecessary calls to the backend.
…ation constants for better organization ♻️ (StorePage/index.tsx): refactor pagination logic to use new pagination constants for clarity and consistency throughout the file
… in ComponentsComponent to improve user experience and performance.
…functionality to improve user experience and data handling in the MyCollectionComponent component
… build query parameter strings for URLs in the frontend controllers.
…te query parameter strings for API requests 📝 (use-get-folder.ts): add comments to explain the purpose of the code and improve code readability 🔧 (use-get-folder.ts): update useGetFolderQuery function to include additional configuration options for the query, such as refetchOnWindowFocus: false
…ter deleting a folder to keep it in sync with the server data
…nId state for refetching queries with the correct folder_id 🐛 (use-post-add-flow.ts): fix queryClient.refetchQueries to include the correct queryKey with folder_id or myCollectionId if response.folder_id is null
… buildQueryStringUrl utility function for better code readability and maintainability
…on functionality to the router for better code organization and readability
Cristhianzl
requested review from
mfortman11,
lucaseduoli,
anovazzi1 and
jordanrfrazier
October 4, 2024 14:14
dosubot
bot
added
size:XL
This PR changes 500-999 lines, ignoring generated files.
enhancement
New feature or request
labels
Oct 4, 2024
github-actions
bot
added
refactor
Maintenance tasks and housekeeping
and removed
enhancement
New feature or request
labels
Oct 4, 2024
This pull request is automatically being deployed by Amplify Hosting (learn more). |
…r code cleanliness and readability
…to handle cancel action in ConfirmationModal. Refactor handleCancel function to improve code readability and maintainability.
…function to clean up code and improve maintainability
…ai/langflow into cz/pagination-refactor
…eGetFolders query with the updated folder_id after patching a flow
…etch queries with the specific folder id when deleting folders
… query parameters for pagination and filtering options
…h useGetFolders query with the correct queryKey and folder_id parameter
…a new flow to ensure the UI is up to date with the latest data.
…ly when isFetched is true to improve performance and reduce unnecessary API calls
…handlePageChange callback for better code organization and readability. Update key prop in ComponentsComponent to include filter and search variables for proper re-rendering.
…y to provide initial data while fetching folder information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will refactor several components related to Folders and Flows.
Backend:
Frontend: