Feat: ReAct #3998
Open
Feat: ReAct #3998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
phact
commented
Oct 3, 2024
phact
commented
- Added an example ReAct test in test_cycles.py
- Made some improvements to the Assistants components (new AssistantManager component that simplifies usage significantly, including dynamic tool usage).
- Added SharedComponentCache and SharedComponentCache service that uses ThreadedInMemoryCache
- Added a new ComponentWithCache to streamline usage of the new cache for things like caching connections / client objects across components. This means all the instances of all the assistants components will use the same OpenAI client.
The `has_cycle_edges` method is added to the `Vertex` class to check if the vertex has any cycle edges. Additionally, the `instantiate_component` method is updated to use the `initialize.loading.instantiate_class` function for custom component instantiation.
- Implement `find_cycle_vertices` function to identify all vertices that are part of cycles in a directed graph. - Utilize depth-first search (DFS) to detect cycles and collect vertices involved in those cycles.
- Introduced `_set_cache_to_vertices_in_cycle` method to enable caching for vertices involved in cycles. - Added `find_cycle_vertices` import to support the new method. - Refactored vertex instantiation into `_instantiate_components_in_vertices` method for better code organization.
Refactor the `_set_cache_to_vertices_in_cycle` method to improve caching logic for vertices involved in cycles. Instead of setting the `cache` attribute to `True`, it is now set to `False` for better clarity and consistency. This change ensures that the cache is properly handled for vertices in cycles.
…and add new test case - Removed the `entry_point` parameter from all test cases for `find_cycle_vertices`. - Added a new parameterized test case `test_handle_two_inputs_in_cycle` to verify handling of cycles with two inputs.
…puts in `base.py`
…ntegration - Introduce `test_updated_graph_with_prompts` to validate graph cyclicity and execution. - Integrate `PromptComponent`, `OpenAIModelComponent`, and `ConditionalRouterComponent` in the test. - Ensure graph execution with a maximum of 20 iterations and cache disabled. - Validate the presence of expected output vertices in the results.
…che in cycle vertices
- Introduced `default_value` to handle cases where edges are cycles and target parameters are present. - Ensured that `default_value` is returned if defined, preventing errors when the component is not built.
…date assertions - Simplified component initialization using method chaining. - Corrected router input and message parameters to use openai_component_1. - Updated assertions to check for correct output IDs.
- Introduced `_cycle_vertices` attribute to store vertices involved in cycles. - Added `cycle_vertices` property to compute and cache cycle vertices. - Updated edge creation logic to use `cycle_vertices` for cycle detection.
- Changed router operator from "equals" to "contains". - Consolidated chat output to a single component. - Updated graph construction to use a single chat output. - Replaced `_snapshot` with `get_snapshot` for graph state capture. - Adjusted assertions to reflect the updated graph structure and outputs.
Merge branch 'assistant-manager' into feat/disablecacheincycle
dosubot
bot
added
size:XL
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
ogabrielluiz
requested changes
Oct 3, 2024
src/backend/base/langflow/custom/custom_component/component_with_cache.py
Outdated
Show resolved
Hide resolved
src/backend/base/langflow/services/shared_component_cache/factory.py
Outdated
Show resolved
Hide resolved
src/backend/base/langflow/services/shared_component_cache/service.py
Outdated
Show resolved
Hide resolved
Comment on lines
+35
to
+39
| DropdownInput( | ||
| display_name="Tool", | ||
| name="tool", | ||
| options=tool_names, | ||
| ), |
There was a problem hiding this comment.
Ideally, the tools would be Components.
What if these tools work as default ones?
There was a problem hiding this comment.
Maybe there's a way to do both, pick from the dropdown if the tools are simple and don't have any configuration or add an edge from a component for more complex tools. We would probably also want a way to accept langchain basetool tools for assistants dynamically.
There was a problem hiding this comment.
You should also be able to pass more than one tool and let it decide which to use. Is there a multi-select input in langflow?
…ory.py Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
…ice.py Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.