Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop execute to be triggered one last time #503

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Stop execute to be triggered one last time #503

merged 2 commits into from
Oct 3, 2024

Conversation

Alopalao
Copy link

Closes #502

Summary

Break loop before NApp.execute() triggers again.

Local Tests

Add log for execute()s and shutting down kytos.

End-to-End Tests

N/A

@Alopalao Alopalao requested a review from a team as a code owner September 30, 2024 14:10
viniarck
viniarck approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@viniarck viniarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement @Alopalao.

I'll leave the PR pre-approved. But changelog needs to be updated before merging, when you do it, go ahead and merge it.

@viniarck viniarck merged commit 87185cd into master Oct 3, 2024
2 checks passed
@viniarck viniarck deleted the feat/shutdown branch October 3, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viniarck viniarck viniarck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NApps trigger a final execute() after shutdown
2 participants
@Alopalao @viniarck