SQLite's OR CONFLICT clause for inserts #976
Open
+244
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functionality not done, only fix type errors
Figured out this is more WYSIWYG than: - Having no 'or' as the default for a method called 'orX' - Appending the 'or' as an override in sqlite-query-compiler
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vincentiusvin
commented
May 1, 2024
vincentiusvin
changed the title
igalklebanov
added
enhancement
igalklebanov
reviewed
May 1, 2024
Good idea. Let's get |
Rename orConflict to orAction Made the action a string instead of a set of specific strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I saw the good first issue tag and was interested in giving this a shot.
I implemented the
orAbort,orFail,orIgnore, etc methods as discussed in #916, alongside making the SQLite override forignore().#510 might be of interest too, since this effectively does what was asked there.
Adding support for
update or Xshould be trivial, but I hope that you won't mind if I keep this PR's scope small.Still got a few design related questions that you can find downstairs, so I'm drafting this.Ready for review.Closes #916