feat: support heap profiling #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #768 +/- ##
===========================================
- Coverage 57.61% 32.69% -24.92%
===========================================
Files 16 15 -1
Lines 729 734 +5
===========================================
- Hits 420 240 -180
- Misses 309 494 +185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jvanz
approved these changes
May 21, 2024
|
I've done the following changes:
|
flavio
force-pushed
the
pprof-heap
branch
2 times, most recently
from
cfafae7
to
cd2db12
Compare
Support the generation of pprof profiles of heap usage by using jemalloc facilities. Signed-off-by: Flavio Castelli <[email protected]>
fabriziosestito
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the generation of pprof profiles of heap usage by using jemalloc facilities.
This requires jemalloc to be configured with some special options, hence all the builds will have this settings enabled. This doesn't seem to cause performance regressions from what I've seen while doing load tests locally.
I've also added some instructions explaining how to memory and CPU profiling.