test: add integration tests #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziosestito
force-pushed
the
test/add-integration-tests
branch
from
7563bf5
to
b9b58cd
Compare
fabriziosestito
commented
Dec 5, 2023
| @@ -0,0 +1,85 @@ | |||
| use policy_server::config::{Config, Policy, PolicyMode}; | |||
There was a problem hiding this comment.
we need the old mod.rs here since otherwise common.rs will be interpreted as a test by cargo. See: https://doc.rust-lang.org/book/ch11-03-test-organization.html#submodules-in-integration-tests
fabriziosestito
force-pushed
the
test/add-integration-tests
branch
from
b9b58cd
to
2426af9
Compare
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
fabriziosestito
force-pushed
the
test/add-integration-tests
branch
from
2426af9
to
654083a
Compare
jvanz
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add policy server integration tests.
The goal is to test that the API are working correctly with the policy evaluator, to then move the runtime related e2e-tests to policy-evaluator.
I've skipped redundant tests (e.g. monitor mode related tests) because we already have unit tests for these scenarios.
Tradeoff
Unfortunately, due to the complexity of the startup of the worker pool, async-sync world bridge and API server, I wasn't able to use the warp test utilities
.
Right now I am starting the http server and using
reqwestagainst it in the integration tests.If we manage to remove the worker pool, we could try to refactor the code so that it is testable without passing from the http stack.