Skip to content

Commit

Permalink
Merge pull request #848 from fabriziosestito/fix/setup-metrics
Browse files Browse the repository at this point in the history
fix: call set_meter_provider
  • Loading branch information
jvanz authored Jul 26, 2024
2 parents ec6abaf + 1e7e344 commit 709a139
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 6 deletions.
2 changes: 1 addition & 1 deletion hack/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ services:
- "16686:16686"
- "4318:4317"
otel-collector:
image: otel/opentelemetry-collector:0.98.0
image: otel/opentelemetry-collector:0.103.0
volumes:
- ./otel-collector-minimal-config.yml:/etc/otel-collector-config.yml
ports:
Expand Down
14 changes: 9 additions & 5 deletions src/metrics.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use opentelemetry::{metrics, KeyValue};
use anyhow::Result;
use opentelemetry::{global, KeyValue};
use opentelemetry_otlp::{ExportConfig, WithExportConfig};
use opentelemetry_sdk::metrics::SdkMeterProvider;
use opentelemetry_sdk::runtime;

mod policy_evaluations_total;
Expand All @@ -10,15 +10,19 @@ pub use policy_evaluations_latency::record_policy_latency;

const METER_NAME: &str = "kubewarden";

pub fn setup_metrics() -> metrics::Result<SdkMeterProvider> {
opentelemetry_otlp::new_pipeline()
pub fn setup_metrics() -> Result<()> {
let meter_provider = opentelemetry_otlp::new_pipeline()
.metrics(runtime::Tokio)
.with_exporter(
opentelemetry_otlp::new_exporter()
.tonic()
.with_export_config(ExportConfig::default()),
)
.build()
.build()?;

global::set_meter_provider(meter_provider.clone());

Ok(())
}

pub trait PolicyEvaluationMetric: Into<Vec<KeyValue>> {}
Expand Down

0 comments on commit 709a139

Please sign in to comment.