refactor!: return CertificateVerficationResponse{} in VerifyCert() #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavio
requested changes
Feb 15, 2024
jvanz
approved these changes
Feb 15, 2024
fabriziosestito
approved these changes
Feb 16, 2024
once comments are addressedpkg/capabilities/VerifyCert() returns a `(bool, err)`. In the case that it
returns `(false, err)`, the error is not a runtime error but it
may contain the reason for the failed certificate verification.
Return a ``(CertificateVerficationResponse{},err)` instead, which contains the
bool trusted and a reason, or a runtime error.
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to kubewarden/cel-policy#15.
pkg/capabilities/VerifyCert()returns a(bool, err). In the case that it returns(false, err), the error is not a runtime error but it may contain the reason for the failed certificate verification.Return a
(CertificateVerficationResponse{},err)instead, which contains the bool trusted and a reason, or a runtime error.Test
CI.
Additional Information
Tradeoff
Potential improvement