feat: settings to skip init and ephemeral containers.

[jvanz]

Description

Adds two settings for the policy that allows the user to skip the verification on init and ephemeral containers.
Furthermore, refactor the policy unit tests to use rstest reducing the number of test functions and duplicate code

Fix #73

Test

make test

[kravciak]

Could you add questions-ui.yml please?

questions:
- default: false
  tooltip: >-
    Ignore that some init container is configured as privileged
  group: Settings
  label: Skip init containers
  required: false
  type: boolean
  variable: skip_init_containers
- default: false
  tooltip: >-
    Ignore that some ephemeral container is configured as privileged
  group: Settings
  label: Skip ephemeral containers
  required: false
  type: boolean
  variable: skip_ephemeral_containers

[jvanz]

@kravciak I've added the questions-ui.yml. Thanks for noticing that! :)

[viccuad]

LGTM

[fabriziosestito]

Maybe it's redundant, but could we add a couple of e2e tests regarding the new feature?

[jvanz]

Maybe it's redundant, but could we add a couple of e2e tests regarding the new feature?

Done. I've also remove bats and start to run the e2e tests in rust.

[jvanz]

To get a green CI in the PR we need to merge this PR and update the reusable workflow.

[flavio]

@jvanz I think there was a misunderstanding. The existing bats test had to be extended, not rewritten in Rust.

Moreover, the tests are failing inside of the GH runner not because of something missing inside of the shared github actions (this PR you created), but because the policy.wasm file is not found.
The Makefile target running the tests has been changed by this PR to remove the dependency against the annotated-policy.wasm file, that leads to a situation where the e2e tests cannot find the policy.wasm file

Can you please undo the changes to the e2e tests and just extend the bats file?

[jvanz]

@jvanz I think there was a misunderstanding. The existing bats test had to be extended, not rewritten in Rust.

Moreover, the tests are failing inside of the GH runner not because of something missing inside of the shared github actions (this PR you created), but because the policy.wasm file is not found. The Makefile target running the tests has been changed by this PR to remove the dependency against the annotated-policy.wasm file, that leads to a situation where the e2e tests cannot find the policy.wasm file

This is not the case. The workflow does not call Makefile targets. It call cargo test. I believe the missing file is the kwctl binary.

Can you please undo the changes to the e2e tests and just extend the bats file?

Yes, I can do it. I was just thinking that running the tests on Rust will be more flexible. As we have done for another rust repositories.

Just one additional note, if we had choose the run the tests on Rust, despite of the makefile changes, the other PR will be still required. Because the command called in the workflow to run the tests is cargo test which runs everything. As the e2e uses kwctl, that will failed due the missing kwctl binary (the test workflow does not install it). That's why I've open that PR to run lib tests only. ;-)

[jvanz]

I've just added a little piece of code to validate if the policy.wasm exists before returning the path to it. The tests are still failing with a different error. Thus, I think the problem is still the missing kwctl binary. Therefore, I believe the comments in this PR and in the github action repo still hold. However, this will not make any difference. I'll be reverting the changes to go back to bats. I was just double checking if my hypothesis makes some sense. ;-)