Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create DOCKER_USER variable for developer to build and push docker image for test #302

Conversation

JohnNiang
Copy link
Member

What this PR dose?

Create DOCKER_USER variable for developer to build and push docker image for test

Why we need it?

Before this PR, if we want to build and push a docker image for test, we may do with the following steps:

Approach 1

  1. Change Makefile and modify surenpai/devops-controller:$(VERSION)-$(COMMIT) to johnniang/devops-controller:$(VERSION)-$(COMMIT)
  2. Execute command: make docker-build-push-controller

Approach 2

  1. Execute make docker-build-push-controller
  2. Execute docker tag surenpi/devops-controller:dev-v3.2.0-alpha.1-7244edd johnniang/devops-controller:dev-v3.2.0-alpha.1-7244edd
  3. Execute docker push johnniang/devops-controller:dev-v3.2.0-alpha.1-7244edd

But now, we just need to execute DOCKER_USER=johnniang make docker-build-push-controller to archive task above.

/kind feature

@ks-ci-bot ks-ci-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 12, 2021
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JohnNiang
To complete the pull request process, please assign linuxsuren after the PR has been reviewed.
You can assign the PR to them by writing /assign @linuxsuren in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 12, 2021
@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #302 (978ee91) into master (6c0564c) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #302      +/-   ##
=========================================
- Coverage    7.64%   7.61%   -0.03%     
=========================================
  Files          90      90              
  Lines       21357   21357              
=========================================
- Hits         1632    1627       -5     
- Misses      19602   19605       +3     
- Partials      123     125       +2     
Flag Coverage Δ
unittests 7.61% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/pipeline/pipeline_controller.go 38.23% <0.00%> (-3.68%) ⬇️
controllers/s2irun/s2irun_controller.go 33.57% <0.00%> (-3.65%) ⬇️
...rs/devopscredential/devopscredential_controller.go 36.48% <0.00%> (+3.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c0564c...978ee91. Read the comment docs.

CONTROLLER_IMG ?= surenpi/devops-controller:$(VERSION)-$(COMMIT)
APISERVER_IMG ?= surenpi/devops-apiserver:$(VERSION)-$(COMMIT)
TOOLS_IMG ?= surenpi/devops-tools:$(VERSION)-$(COMMIT)
DOCKER_USER ?= surenpi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer changing this to kubespheredev

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, surenpi is my personal account. But kubespheredev is not a user account. So, I suggest replacing DOCKER_USER to be a better name.

@JohnNiang
Copy link
Member Author

Due to LinuxSuRen/open-source-best-practice#33, I'm going to close this PR and let this chance leave to new contributors.

/close

@JohnNiang JohnNiang closed this Oct 12, 2021
@JohnNiang JohnNiang deleted the refactor/makefile-build-and-push branch October 13, 2021 06:07
@JohnNiang JohnNiang requested a review from a team October 14, 2021 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants