Document labels, annotations and taints for JobSet #49217
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/assign @sftim |
| placement per topology group. You can also define this label or annotation on a replicated job | ||
| template. Read the documentation for JobSet to learn more. | ||
|
|
||
| ### alpha.jobset.sigs.k8s.io/node-selector |
There was a problem hiding this comment.
Ideally we can mark this deprecated (it should be), but: can wait for a follow up PR.
There was a problem hiding this comment.
we will deprecate when we graduate to stable
| The JobSet controller sets this label (and also an annotation with the same key) on child Jobs and | ||
| Pods of a JobSet. The value is the SHA256 hash of the namespaced Job name. | ||
|
|
||
| ### alpha.jobset.sigs.k8s.io/exclusive-topology |
There was a problem hiding this comment.
Ideally we can mark this deprecated (it should be), but: can wait for a follow up PR.
|
|
||
| The JobSet controller adds this label/annotation to Jobs and Pods that are part of a JobSet. It stores the namespaced Job name, which is used for logging and event management within the JobSet context. | ||
|
|
||
| ### alpha.jobset.sigs.k8s.io/no-schedule |
There was a problem hiding this comment.
Ideally we can mark this deprecated (it should be), but: can wait for a follow up PR.
|
|
||
| This label/annotation can be applied to a JobSet. When it's set, the JobSet controller modifies the Jobs and their corresponding Pods by adding node selectors. This ensures exclusive job placement per topology domain, restricting the scheduling of these Pods to specific nodes based on the strategy. | ||
|
|
||
| ### alpha.jobset.sigs.k8s.io/namespaced-job |
There was a problem hiding this comment.
Ideally we can mark this deprecated (it should be), but: can wait for a follow up PR.
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c147a634d16794eb5b6e45ad418f3fcc4f456c53
|
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
LGTM from jobset side. |
|
Thanks @sftim for the review? who can approve this? |
|
This represents a change to the live site. If this gets formal LGTM (ie, use the /lgtm Prow command) or formal approval from someone other than me, I can approve it. |
k8s-ci-robot
removed
the
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
c68175e doesn't make sense to me @ahg-g. It's a label, and it both is and isn't an annotation? It's used on Nodes, but it's also used on Jobs and Pods but not Nodes? Clarify if you can. See the force push diff for a clearer view on this. |
ahg-g
force-pushed
the
jobset
branch
2 times, most recently
from
bb62bef to
04fb6be
Compare
|
/lgtm There is clearly more to fix; we can address that in a follow-up good-first-issue (we actually really like good first issues!) |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9d45544f1ac8686deff047d975875ec39253eedc
|
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
Fixed the wording, can you approve this too? |
|
It's still a change to the live site. By convention, we get two reviews on these unless they are tiny @ahg-g. Do you know any Kubernetes contributors who can provide the other review? |
|
@kannon92 just lgtmed above; or do we need a docs owner to review? |
This is a followup to #47383