Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename feature gate files to use gate names #49202

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rename feature gate files to use gate names #49202

wants to merge 1 commit into from

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Dec 22, 2024

The conversion to/from snake-case was not necessary and it is causing mental burden and extra labor in resyncing changes.

Description

Issue

Closes: #

@tengqm
Rename feature gate files to use gate names
c8f3659 
The conversion to/from snake-case was not necessary and it is
causing mental burden and extra labor in resyncing changes.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 22, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Dec 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tengqm. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 22, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 22, 2024

✅ Pull request preview available for checking

Name Link
🔨 Latest commit c8f3659
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6767932b710fa60008f18b54
😎 Deploy Preview https://deploy-preview-49202--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sftim
sftim reviewed Dec 22, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, you must also update the contributor docs when making this change @tengqm.

Missing that out means we can't / shouldn't merge this, no matter how frustrated you feel about the matter.

@tengqm
Copy link
Contributor Author

tengqm commented Dec 23, 2024

@sftim #47863

@sftim
Copy link
Contributor

sftim commented Dec 23, 2024

/hold

pending merge of #47863

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@salaxander salaxander Awaiting requested review from salaxander

@windsonsea windsonsea Awaiting requested review from windsonsea

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tengqm @k8s-ci-robot @sftim