-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CVSS v4.0 support, fix CVSS v2.0 invalid calculator link #3474
base: master
Are you sure you want to change the base?
Conversation
Hi @pandatix. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pandatix The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
894cabe
to
af1a9d3
Compare
af1a9d3
to
43b9770
Compare
43b9770
to
4e9d360
Compare
4e9d360
to
7076069
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Lucas TESSON <[email protected]>
7076069
to
366f3d0
Compare
The NVD has now official support of CVSS v4.0 (https://nvd.nist.gov/general/news/cvss-v4-0-official-support), may be a good time to re-evaluate this PR. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
What type of PR is this?
/kind feature
/kind cleanup
What this PR does / why we need it:
FIRST.ORG SIG CVSS (which I'm part of) released CVSS v4.0 months ago, and we see adoption going on in the whole ecosystem. Nevertheless, Kubernetes is not ready yet to handle those new vectors... but not for long ! 🎉
Through this PR, I bring the possibility to handle CVSS v4.0 vector strings. Moreover, I fix the calculator link computation as the FIRST.ORG does not have a calculator for CVSS v2.0, which technically produced 404 URLs despite it is no longer used by the community.
Which issue(s) this PR fixes:
Did not open an issue for the CVSS v2.0 calculator link, though it was irrelevant as will affect people relying on CVSS v2.0 vector strings which will most likely be nobody.
Special notes for your reviewer:
Does this PR introduce a user-facing change?