Use a different bucket for pod-identity-webhook discovery store #16874
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
hakman
approved these changes
Oct 4, 2024
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This job is currently failing because its trying to reuse the kops state store for discovery documents and the state store s3 bucket doesn't support ACLs
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/e2e-kops-aws-pod-identity-webhook/1841974219194241024
W1003 22:59:03.893406 14665 executor.go:141] error running task "ManagedFile/keys.json" (9m33s remaining to succeed): error creating ManagedFile "openid/v1/jwks": error writing s3://k8s-kops-ci-prow-state-store/e2e-49d63c55eb-ac683.tests-kops-aws.k8s.io/openid/v1/jwks (with ACL="public-read"): operation error S3: PutObject, https response error StatusCode: 400, RequestID: S4Q35EVQAWC6XCSQ, HostID: qwNOSCxjfBeio8cM845/Od/jn/d83NGKVOO8igAOXzUbe3fUUA4/ow51TSY9EBzBXEy2w8XXLnfTT97wRXocGg==, api error AccessControlListNotSupported: The bucket does not allow ACLsWe have a separate bucket for public-read ACLs:
https://github.com/kubernetes/k8s.io/blob/35e7931e4042a437ec719bd56991fe46467e5f20/infra/aws/terraform/kops-infra-ci/main.tf#L49-L78
This updates the e2e job to use that new bucket.
As an aside, other e2e jobs use a different s3 bucket and I'm not sure which account it lives in but it seems to work:
https://github.com/kubernetes/test-infra/blob/9bd543de4b91a940ebe23b3e56fcc64c2aca1651/config/jobs/kubernetes/kops/build_jobs.py#L130-L133
If this pod identity webhook job is fixed by this change, I'll update the remaining e2e jobs to use this new bucket as well.